Differential D15027

Add link to Herald Transaction when blocking pushes
ClosedPublic
Actions

Authored by avivey on Jan 15 2016, 2:59 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess

Commits

Restricted Diffusion Commit
rP98d237067246: Add link to Herald Transaction when blocking pushes

Summary

Ref T9719.

Test Plan

Tried to push, get dragon and a link.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10117
Build 12267: Run Core Tests
Build 12266: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 36285.Jan 15 2016, 2:59 AM

avivey retitled this revision from to Add link to Herald Transaction when blocking pushes.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a task: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2016, 2:59 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Jan 15 2016, 2:59 AM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Jan 15 2016, 2:59 AM

Closed by commit rP98d237067246: Add link to Herald Transaction when blocking pushes (authored by avivey, committed by avivey). · Explain WhyJan 15 2016, 3:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

13 lines

Diff 36285

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Add link to Herald Transaction when blocking pushesClosedPublicActions