Page MenuHomePhabricator
Differential D14984

Give `<hr />` in remarkup `clear: both`
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 12:25 PM
Unknown Object (File)
Fri, Jan 24, 11:05 AM
Unknown Object (File)
Thu, Jan 23, 11:21 PM
Unknown Object (File)
Tue, Jan 21, 11:06 AM
Unknown Object (File)
Dec 29 2024, 11:49 AM
Unknown Object (File)
Dec 28 2024, 7:23 PM
Unknown Object (File)
Dec 28 2024, 7:23 PM
Unknown Object (File)
Dec 28 2024, 7:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10110: Floating images in Phriction can make everything else afterwards float... forever
Commits
Restricted Diffusion Commit
rP01fba3432707: Give `<hr />` in remarkup `clear: both`
Summary

Ref T10110.

Test Plan

Before:

Screen Shot 2016-01-10 at 6.20.18 AM.png (787×1 px, 165 KB)

After:

Screen Shot 2016-01-10 at 6.20.29 AM.png (819×1 px, 166 KB)

Diff Detail

Repository
rP Phabricator
Branch
hrclear1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10034
Build 12136: Run Core Tests
Build 12135: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36195.Jan 10 2016, 2:21 PM
epriestley retitled this revision from to Give `<hr />` in remarkup `clear: both`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10110: Floating images in Phriction can make everything else afterwards float... forever.
Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 2:21 PM
epriestley mentioned this in T10110: Floating images in Phriction can make everything else afterwards float... forever.Jan 10 2016, 3:56 PM
epriestley updated this revision to Diff 36200.Jan 10 2016, 4:01 PM
epriestley edited edge metadata.
  • Also clear all headers that have rules in CSS. Not sure Remarkup can actually generate all of these, but the rules are narrow.
Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 4:01 PM
chad edited edge metadata.Jan 10 2016, 5:15 PM

It's probably safest to just do the hr when I think about it. We're also limiting layout options here by putting it on all headers. I was mostly suggesting just the largest header.

epriestley added a comment.Jan 10 2016, 5:17 PM

Yeah, that's reasonable.

epriestley updated this revision to Diff 36201.Jan 10 2016, 5:18 PM
epriestley edited edge metadata.
  • Just <hr />.
chad accepted this revision.Jan 10 2016, 5:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 5:27 PM
Closed by commit rP01fba3432707: Give `<hr />` in remarkup `clear: both` (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 5:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
7 lines

Diff 36200

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility