Page MenuHomePhabricator
Differential D14984

Give `<hr />` in remarkup `clear: both`
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 2:21 PM.
Tags
None
Referenced Files
F14062766: D14984.diff
Mon, Nov 18, 2:22 PM
F14053936: D14984.diff
Fri, Nov 15, 8:46 PM
F14041943: D14984.diff
Mon, Nov 11, 11:06 PM
F14040625: D14984.id36200.diff
Mon, Nov 11, 11:42 AM
F14039917: D14984.id36201.diff
Mon, Nov 11, 6:43 AM
F14028796: D14984.diff
Fri, Nov 8, 4:06 PM
F14019429: D14984.id36201.diff
Tue, Nov 5, 10:06 PM
F13972142: D14984.id.diff
Oct 17 2024, 5:20 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10110: Floating images in Phriction can make everything else afterwards float... forever
Commits
Restricted Diffusion Commit
rP01fba3432707: Give `<hr />` in remarkup `clear: both`
Summary

Ref T10110.

Test Plan

Before:

Screen Shot 2016-01-10 at 6.20.18 AM.png (787×1 px, 165 KB)

After:

Screen Shot 2016-01-10 at 6.20.29 AM.png (819×1 px, 166 KB)

Diff Detail

Repository
rP Phabricator
Branch
hrclear1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10034
Build 12136: Run Core Tests
Build 12135: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36195.Jan 10 2016, 2:21 PM
epriestley retitled this revision from to Give `<hr />` in remarkup `clear: both`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10110: Floating images in Phriction can make everything else afterwards float... forever.
Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 2:21 PM
epriestley mentioned this in T10110: Floating images in Phriction can make everything else afterwards float... forever.Jan 10 2016, 3:56 PM
epriestley updated this revision to Diff 36200.Jan 10 2016, 4:01 PM
epriestley edited edge metadata.
  • Also clear all headers that have rules in CSS. Not sure Remarkup can actually generate all of these, but the rules are narrow.
Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 4:01 PM
chad edited edge metadata.Jan 10 2016, 5:15 PM

It's probably safest to just do the hr when I think about it. We're also limiting layout options here by putting it on all headers. I was mostly suggesting just the largest header.

epriestley added a comment.Jan 10 2016, 5:17 PM

Yeah, that's reasonable.

epriestley updated this revision to Diff 36201.Jan 10 2016, 5:18 PM
epriestley edited edge metadata.
  • Just <hr />.
chad accepted this revision.Jan 10 2016, 5:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 5:27 PM
Closed by commit rP01fba3432707: Give `<hr />` in remarkup `clear: both` (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 5:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
7 lines

Diff 36200

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility