Page MenuHomePhabricator
Differential D14949

Fix all remaining weird Diffusion request processing
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 9:04 PM.
Tags
None
Referenced Files
F13087774: D14949.diff
Thu, Apr 25, 1:05 AM
Unknown Object (File)
Sun, Apr 21, 1:37 PM
Unknown Object (File)
Fri, Apr 19, 4:03 PM
Unknown Object (File)
Sun, Apr 14, 10:12 PM
Unknown Object (File)
Thu, Apr 11, 7:05 AM
Unknown Object (File)
Sun, Apr 7, 3:04 PM
Unknown Object (File)
Thu, Apr 4, 3:34 PM
Unknown Object (File)
Wed, Apr 3, 12:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPf9a5cd2bbd86: Fix all remaining weird Diffusion request processing
Summary

Ref T4245. This is the last of it, and covers the clone/push stuff.

Test Plan
  • Cloned git.
  • Pushed git.
  • Cloned mercurial.
  • Pushed mercurial.
  • Visited a blah.git URL in my browser just because; got redirected to a human-facing UI.

Diff Detail

Repository
rP Phabricator
Branch
call10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9937
Build 11997: Run Core Tests
Build 11996: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36112.Jan 5 2016, 9:04 PM
epriestley retitled this revision from to Fix all remaining weird Diffusion request processing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 5 2016, 9:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2016, 9:28 PM
Closed by commit rPf9a5cd2bbd86: Fix all remaining weird Diffusion request processing (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
application/
5 lines
controller/
49 lines
5 lines
27 lines
request/
37 lines

Diff 36112

View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility