Page MenuHomePhabricator
Differential D14932

Convert `diffusion.looksoon` to use repository identifiers instead of callsigns
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 8:04 PM.
Tags
None
Referenced Files
F15481286: D14932.id36075.diff
Tue, Apr 8, 7:49 PM
F15479969: D14932.id.diff
Tue, Apr 8, 10:32 AM
F15479647: D14932.id36084.diff
Tue, Apr 8, 8:34 AM
F15477126: D14932.diff
Mon, Apr 7, 12:41 PM
F15456283: D14932.diff
Sun, Mar 30, 8:24 AM
F15425063: D14932.id36084.diff
Sun, Mar 23, 2:19 AM
F15395203: D14932.id36075.diff
Sun, Mar 16, 3:36 AM
F15394862: D14932.id.diff
Sun, Mar 16, 1:33 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP9febfb26a08d: Convert `diffusion.looksoon` to use repository identifiers instead of callsigns
Summary

Ref T4245. Like everything else, accept more identifiers.

This needs a change in arc, which I've made a note about elsewhere.

Test Plan

Used "Update Now" from web UI, saw update get scheduled.

Diff Detail

Repository
rP Phabricator
Branch
callsign9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9899
Build 11939: Run Core Tests
Build 11938: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36075.Jan 2 2016, 8:04 PM
epriestley retitled this revision from to Convert `diffusion.looksoon` to use repository identifiers instead of callsigns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 3 2016, 4:52 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2016, 4:52 AM
Closed by commit rP9febfb26a08d: Convert `diffusion.looksoon` to use repository identifiers instead of callsigns (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2016, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
4 lines
diffusion/
conduit/
14 lines
controller/
2 lines
4 lines

Diff 36075

View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php

Loading...
Phabricator · Built by Phacility