Page MenuHomePhabricator
Files F15394862

D14932.id.diff
No OneTemporary
Actions

D14932.id.diff
View Options

diff --git a/src/applications/differential/controller/DifferentialRevisionLandController.php b/src/applications/differential/controller/DifferentialRevisionLandController.php
--- a/src/applications/differential/controller/DifferentialRevisionLandController.php
+++ b/src/applications/differential/controller/DifferentialRevisionLandController.php
@@ -146,7 +146,7 @@
$looksoon = new ConduitCall(
'diffusion.looksoon',
array(
- 'callsigns' => array($repository->getCallsign()),
+ 'repositories' => array($repository->getPHID()),
));
$looksoon->setUser($request->getUser());
$looksoon->execute();
@@ -155,7 +155,7 @@
}
private function lockRepository($repository) {
- $lock_name = __CLASS__.':'.($repository->getCallsign());
+ $lock_name = __CLASS__.':'.($repository->getPHID());
$lock = PhabricatorGlobalLock::newLock($lock_name);
$lock->lock();
return $lock;
diff --git a/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php
@@ -24,7 +24,8 @@
protected function defineParamTypes() {
return array(
- 'callsigns' => 'required list<string>',
+ 'callsigns' => 'optional list<string> (deprecated)',
+ 'repositories' => 'optional list<string>',
'urgency' => 'optional string',
);
}
@@ -33,14 +34,19 @@
// NOTE: The "urgency" parameter does nothing, it is just a hilarious joke
// which exemplifies the boundless clever wit of this project.
- $callsigns = $request->getValue('callsigns');
- if (!$callsigns) {
+ $identifiers = $request->getValue('repositories');
+
+ if (!$identifiers) {
+ $identifiers = $request->getValue('callsigns');
+ }
+
+ if (!$identifiers) {
return null;
}
$repositories = id(new PhabricatorRepositoryQuery())
->setViewer($request->getUser())
- ->withCallsigns($callsigns)
+ ->withIdentifiers($identifiers)
->execute();
foreach ($repositories as $repository) {
diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -212,7 +212,7 @@
'path' => '',
)),
),
- 'r'.$drequest->getRepository()->getCallsign());
+ $drequest->getRepository()->getDisplayName());
$links[] = $divider;
$accum = '';
$last_key = last_key($path_parts);
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditUpdateController.php
@@ -25,8 +25,8 @@
if ($request->isFormPost()) {
$params = array(
- 'callsigns' => array(
- $repository->getCallsign(),
+ 'repositories' => array(
+ $repository->getPHID(),
),
);

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 1:33 AM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7326765
Default Alt Text
D14932.id.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility