Page MenuHomePhabricator
Differential D14925

Fix an issue with rendering some commit hovercards
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 1:09 PM.
Tags
None
Referenced Files
F13311657: D14925.diff
Tue, Jun 11, 5:19 AM
F13308034: D14925.diff
Mon, Jun 10, 12:06 AM
F13298310: D14925.diff
Fri, Jun 7, 6:35 AM
F13290919: D14925.id36067.diff
Tue, Jun 4, 8:32 PM
F13290918: D14925.id36064.diff
Tue, Jun 4, 8:32 PM
F13290916: D14925.id.diff
Tue, Jun 4, 8:32 PM
F13290915: D14925.diff
Tue, Jun 4, 8:32 PM
F13282992: D14925.diff
Sun, Jun 2, 12:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP1b4f5e38cec3: Fix an issue with rendering some commit hovercards
Summary

This logic wasn't quite right.

Test Plan

Hovered over a recognized commit, got a valid hovercard

Diff Detail

Repository
rP Phabricator
Branch
dxhover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9887
Build 11919: Run Core Tests
Build 11918: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36064.Jan 2 2016, 1:09 PM
epriestley retitled this revision from to Fix an issue with rendering some commit hovercards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 2 2016, 3:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 3:42 PM
Closed by commit rP1b4f5e38cec3: Fix an issue with rendering some commit hovercards (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2016, 7:03 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in P1929 Hovercards are Exceptional.Jan 22 2016, 9:39 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engineextension/
2 lines

Diff 36064

View Options

src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php

Loading...
Phabricator · Built by Phacility