Page MenuHomePhabricator
Differential D14924

Remove calls to getCallsign() in bin/repository scripts
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 5:50 AM
Unknown Object (File)
Fri, Apr 19, 4:00 PM
Unknown Object (File)
Wed, Apr 10, 11:54 PM
Unknown Object (File)
Mon, Apr 8, 7:27 AM
Unknown Object (File)
Sat, Apr 6, 9:43 PM
Unknown Object (File)
Mar 21 2024, 5:42 AM
Unknown Object (File)
Mar 5 2024, 5:20 PM
Unknown Object (File)
Mar 5 2024, 5:20 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPedcc3232aabc: Remove calls to getCallsign() in bin/repository scripts
Summary

Ref T4245. Prepare these scripts for a callsign-free world. This also makes them more flexible and easier to use.

The following are now valid ways to identify a repository for these scripts: ID (3), PHID (PHID-REPO-wxyz), R<ID> (R3), r<CALLSIGN> (rSKYNET), CALLSIGN (SKYNET).

In the future, a human-readable label (skynet) may also become valid.

Test Plan
  • Ran bin/repository reparse --all ... with rX, X, 3, R3.
  • Ran bin/repository reparse --change ... with rXaaa, including short versions.
  • Ran bin/repository update ... with rX, X, 3, R3.
  • Ran bin/repository refs ... with various identifiers.
  • Ran bin/repository pull ... with various identifiers.
  • Ran bin/repository mirror ... with various identifiers.
  • Ran bin/repository mark-imported ... with various identifiers.
  • Ran bin/repository list.
  • Ran bin/repository importing ... with various identifiers and examined output.
  • Ran bin/repository edit ... with various identifiers.
  • Ran bin/repository discover ... with various identifiers.

Diff Detail

Repository
rP Phabricator
Branch
callsign2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/storage/PhabricatorRepository.php:155XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9882
Build 11913: Run Core Tests
Build 11912: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36060.Jan 2 2016, 2:53 AM
epriestley retitled this revision from to Remove calls to getCallsign() in bin/repository scripts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 2 2016, 2:59 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 2:59 AM
Closed by commit rPedcc3232aabc: Remove calls to getCallsign() in bin/repository scripts (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2016, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36060

View Options

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility