Page MenuHomePhabricator

Remove calls to getCallsign() in bin/repository scripts
ClosedPublic

Authored by epriestley on Jan 2 2016, 2:53 AM.
Tags
None
Referenced Files
F19087331: D14924.id36062.diff
Wed, Dec 3, 12:17 AM
F19087329: D14924.id36060.diff
Wed, Dec 3, 12:17 AM
F19087328: D14924.id.diff
Wed, Dec 3, 12:17 AM
F19080231: D14924.diff
Tue, Dec 2, 12:24 AM
F18852168: D14924.id36062.diff
Oct 31 2025, 7:12 AM
F18736629: D14924.id36060.diff
Oct 1 2025, 6:56 AM
F18696933: D14924.id36062.diff
Sep 27 2025, 8:38 AM
F18695065: D14924.id36062.diff
Sep 27 2025, 5:00 AM
Subscribers
None

Details

Summary

Ref T4245. Prepare these scripts for a callsign-free world. This also makes them more flexible and easier to use.

The following are now valid ways to identify a repository for these scripts: ID (3), PHID (PHID-REPO-wxyz), R<ID> (R3), r<CALLSIGN> (rSKYNET), CALLSIGN (SKYNET).

In the future, a human-readable label (skynet) may also become valid.

Test Plan
  • Ran bin/repository reparse --all ... with rX, X, 3, R3.
  • Ran bin/repository reparse --change ... with rXaaa, including short versions.
  • Ran bin/repository update ... with rX, X, 3, R3.
  • Ran bin/repository refs ... with various identifiers.
  • Ran bin/repository pull ... with various identifiers.
  • Ran bin/repository mirror ... with various identifiers.
  • Ran bin/repository mark-imported ... with various identifiers.
  • Ran bin/repository list.
  • Ran bin/repository importing ... with various identifiers and examined output.
  • Ran bin/repository edit ... with various identifiers.
  • Ran bin/repository discover ... with various identifiers.

Diff Detail

Repository
rP Phabricator
Branch
callsign2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/storage/PhabricatorRepository.php:155XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9882
Build 11913: Run Core Tests
Build 11912: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove calls to getCallsign() in bin/repository scripts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 2:59 AM
This revision was automatically updated to reflect the committed changes.