Page MenuHomePhabricator
Differential D14887

Support field previews in EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 26 2015, 9:08 PM.
Tags
None
Referenced Files
F17839857: D14887.diff
Sat, Jul 26, 8:31 PM
F17691798: D14887.id35983.diff
Tue, Jul 15, 12:24 AM
Unknown Object (File)
May 31 2025, 8:45 PM
Unknown Object (File)
May 30 2025, 5:50 AM
Unknown Object (File)
May 27 2025, 6:57 PM
Unknown Object (File)
May 26 2025, 3:27 PM
Unknown Object (File)
May 25 2025, 6:48 AM
Unknown Object (File)
May 10 2025, 1:15 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
rPaa2089ba6804: Support field previews in EditEngine
Summary

Ref T10004. This primarily supports moving Phame to EditEngine.

Test Plan

Screen Shot 2015-12-26 at 1.06.44 PM.png (1×1 px, 209 KB)

Diff Detail

Repository
rP Phabricator
Branch
preview1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9807
Build 11797: Run Core Tests
Build 11796: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35983.Dec 26 2015, 9:08 PM
epriestley updated this revision to Diff 35984.
epriestley retitled this revision from to Support field previews in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10004: ApplicationEditor Errata.
  • Less debugging code.
chad accepted this revision.Dec 27 2015, 4:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2015, 4:05 PM
Closed by commit rPaa2089ba6804: Support field previews in EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 27 2015, 4:17 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D14802: Update PhamePost to EditEngine.Dec 27 2015, 4:18 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
maniphest/
application/
7 lines
editor/
5 lines
transactions/
controller/
4 lines
editengine/
25 lines
editfield/
22 lines
webroot/
rsrc/
js/
core/
2 lines
14 lines

Diff 35984

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionRemarkupPreviewController.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
View Options

webroot/rsrc/js/core/behavior-remarkup-preview.js

Loading...
Phabricator · Built by Phacility