Page MenuHomePhabricator

Update PhamePost to EditEngine
ClosedPublic

Authored by chad on Dec 16 2015, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Wed, Nov 23, 11:11 PM
Unknown Object (File)
Mon, Nov 14, 2:05 PM
Unknown Object (File)
Sat, Nov 12, 7:59 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP10ed33052361: Update PhamePost to EditEngine
Summary

Allows create and edit workflows through EditEngine. Not sure I did the 'blog' stuff correct.

Test Plan

Create a new post, edit a post, move a post.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Update PhamePost to EditEngine.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

I should note this need to wait on a document preview as well.

I think the blog stuff is OK. We might be able to clean up the part where it loads it eventually, but that seems fine for now.

Let me take a look at hooking up previews on top of this.

src/applications/phame/controller/post/PhamePostEditController.php
34

We should have a if (!$blog) { return new Aphront404Response(); } bit here.

chad edited edge metadata.
  • !blog

I'm tentatively going to see if I can move forward with T3967 to provide previews.

epriestley edited edge metadata.

You should be able to use setPreviewPanel() to get the previews working now after D14887, let me know if you run into issues.

This revision is now accepted and ready to land.Dec 27 2015, 4:18 PM
chad edited edge metadata.
  • !blog
  • update to new edit stuff
src/applications/phame/editor/PhamePostEditEngine.php
35

This causes issues if actually trying to create a new blog post form, since $blog is required for a new post. Not sure what the correct fix is.

I think you can probably do something like this:

$viewer = $this->getViewer();

if ($this->blog) {
  $blog = $this->blog;
} else {
  $blog = PhameBlog::initializeNewBlog($viewer);
}

return PhamePost::initializePost($viewer, $blog);

Basically, just make a dummy empty blog for the meta-edit-form-edit stuff.

This revision was automatically updated to reflect the committed changes.