Paths

Table of Contentst

Differential D14858

Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults
ClosedPublic
Actions

Authored by epriestley on Dec 23 2015, 2:22 AM.

Details

Reviewers

chad

Maniphest Tasks

T10004: ApplicationEditor Errata

Commits

Restricted Diffusion Commit
rPbb8cf8eca8c3: Fix incorrect rendering of "Spaces" dropdown control when configuring…

Summary

Ref T10004. This could sometimes pass false, which counts as disabled.

Instead, pass null explicitly.

Test Plan

Edited default space on an EditEngine form.

Diff Detail

Repository

rP Phabricator

Branch

spacedefault

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9739
Build 11691: Run Core Tests
Build 11690: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35920.Dec 23 2015, 2:22 AM

epriestley retitled this revision from to Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10004: ApplicationEditor Errata.

chad accepted this revision.Dec 23 2015, 2:38 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 23 2015, 2:38 AM

Closed by commit rPbb8cf8eca8c3: Fix incorrect rendering of "Spaces" dropdown control when configuring… (authored by epriestley, committed by epriestley). · Explain WhyDec 23 2015, 2:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormPolicyControl.php

2 lines

Diff 35920

View Options

src/view/form/control/AphrontFormPolicyControl.php

Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaultsClosedPublicActions