Page MenuHomePhabricator

Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults
ClosedPublic

Authored by epriestley on Dec 23 2015, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 4:03 AM
Unknown Object (File)
Sun, Feb 9, 12:15 AM
Unknown Object (File)
Sun, Feb 9, 12:15 AM
Unknown Object (File)
Sun, Feb 9, 12:14 AM
Unknown Object (File)
Thu, Feb 6, 11:40 PM
Unknown Object (File)
Tue, Jan 28, 12:30 AM
Unknown Object (File)
Jan 26 2025, 2:11 AM
Unknown Object (File)
Jan 26 2025, 1:54 AM
Subscribers
None

Details

Summary

Ref T10004. This could sometimes pass false, which counts as disabled.

Instead, pass null explicitly.

Test Plan

Edited default space on an EditEngine form.

Diff Detail

Repository
rP Phabricator
Branch
spacedefault
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9739
Build 11691: Run Core Tests
Build 11690: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 2:38 AM
This revision was automatically updated to reflect the committed changes.