Page MenuHomePhabricator

Add a pirate translation
ClosedPublic

Authored by chad on Dec 20 2015, 3:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 10:36 AM
Unknown Object (File)
Thu, Dec 12, 2:13 AM
Unknown Object (File)
Mon, Dec 9, 12:47 PM
Unknown Object (File)
Mon, Dec 9, 12:43 AM
Unknown Object (File)
Thu, Dec 5, 4:32 PM
Unknown Object (File)
Sat, Nov 30, 7:54 PM
Unknown Object (File)
Fri, Nov 29, 10:56 AM
Unknown Object (File)
Wed, Nov 27, 3:49 PM
Tokens
"Mountain of Wealth" token, awarded by hach-que."Doubloon" token, awarded by joshuaspence."Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP006321cce76b: Add a pirate translation
Summary

Basic Pirate, mostly Maniphest

Test Plan

Play lots with Maniphest

Diff Detail

Repository
rP Phabricator
Branch
arrr (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9676
Build 11596: Run Core Tests
Build 11595: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add a pirate translation.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Haha, these are great.

src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
29

tails -> tales

This revision is now accepted and ready to land.Dec 20 2015, 2:52 PM
This revision was automatically updated to reflect the committed changes.

I wonder if "capn" would be better as "cap'n".

src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
30

It would be slightly nicer to use double quotes instead to avoid escaping the inline single quote, i.e. "Capn's Tales".

hach-que added inline comments.
src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
58–61

Are these around the wrong way?