Page MenuHomePhabricator

Provide a "PHUIFormIconSetControl"
ClosedPublic

Authored by epriestley on Dec 16 2015, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 5:30 PM
Unknown Object (File)
Fri, Jan 24, 1:22 AM
Unknown Object (File)
Wed, Jan 22, 3:07 PM
Unknown Object (File)
Tue, Jan 21, 10:35 AM
Unknown Object (File)
Jan 1 2025, 1:23 AM
Unknown Object (File)
Dec 29 2024, 1:59 PM
Unknown Object (File)
Dec 29 2024, 6:59 AM
Unknown Object (File)
Dec 28 2024, 4:16 PM
Subscribers
None

Details

Summary

Ref T9992. This is a step on the path to getting EditEngine working in Badges, Projects and Calendar.

This doesn't add a new EditField for icons yet, just standardizes the old stuff. New stuff is more general and I saved 150 lines of code.

I put the endpoint in Files because the similar "choose a profile picture" endpoint will definitely go there, and this endpoint might eventually feature, like, "draw your own icon~~" or something.

Test Plan
  • Created events, projects and badges with custom icons.
  • Edited events, projects and badges, changing their icons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a "PHUIFormIconSetControl".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 4:37 PM
This revision was automatically updated to reflect the committed changes.