Page MenuHomePhabricator

Provide a "PHUIFormIconSetControl"
ClosedPublic

Authored by epriestley on Dec 16 2015, 4:34 PM.
Tags
None
Referenced Files
F14475864: D14799.diff
Fri, Dec 27, 9:33 PM
Unknown Object (File)
Thu, Dec 19, 7:43 AM
Unknown Object (File)
Fri, Dec 6, 8:38 PM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Unknown Object (File)
Sun, Dec 1, 12:14 PM
Unknown Object (File)
Fri, Nov 29, 5:39 PM
Subscribers
None

Details

Summary

Ref T9992. This is a step on the path to getting EditEngine working in Badges, Projects and Calendar.

This doesn't add a new EditField for icons yet, just standardizes the old stuff. New stuff is more general and I saved 150 lines of code.

I put the endpoint in Files because the similar "choose a profile picture" endpoint will definitely go there, and this endpoint might eventually feature, like, "draw your own icon~~" or something.

Test Plan
  • Created events, projects and badges with custom icons.
  • Edited events, projects and badges, changing their icons.

Diff Detail

Repository
rP Phabricator
Branch
ee10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/iconset/PhabricatorIconSet.php:26XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9597
Build 11481: Run Core Tests
Build 11480: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide a "PHUIFormIconSetControl".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 4:37 PM
This revision was automatically updated to reflect the committed changes.