Page MenuHomePhabricator
Differential D14746

Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment
ClosedPublic
Actions

Authored by epriestley on Dec 12 2015, 1:03 AM.
Tags
None
Referenced Files
F14065374: D14746.diff
Tue, Nov 19, 4:25 AM
F14051539: D14746.diff
Fri, Nov 15, 1:48 AM
F14048743: D14746.id.diff
Thu, Nov 14, 9:31 AM
F14048039: D14746.id35665.diff
Thu, Nov 14, 6:34 AM
F14047947: D14746.id.diff
Thu, Nov 14, 5:55 AM
F14045735: D14746.id35663.diff
Wed, Nov 13, 10:04 AM
F14045586: D14746.id35663.diff
Wed, Nov 13, 6:46 AM
F14037894: D14746.diff
Sun, Nov 10, 7:54 PM
View All Files
Subscribers
None
Tokens
"Evil Spooky Haunted Tree" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rP4b77bbd60c24: Clarify that the "Add Comment" button might not literally add a comment if…
Summary

Ref T9908.

Test Plan

Careful reading.

Diff Detail

Repository
rP Phabricator
Branch
ux1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9482
Build 11303: Run Core Tests
Build 11302: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35662.Dec 12 2015, 1:03 AM
epriestley retitled this revision from to Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
chad edited edge metadata.Dec 12 2015, 1:04 AM

yudodis

epriestley added a comment.Dec 12 2015, 1:05 AM

huehuehuehuehuehue

epriestley updated this revision to Diff 35663.Dec 12 2015, 1:06 AM
epriestley edited edge metadata.

Bland version.

I don't know if "Take Action" is too un-serious? Or how much flavor I can get into "Submit"?

epriestley added a comment.Dec 12 2015, 1:07 AM

(Maybe leaving "Add Comment" as the header is fine? But if we're changing the button it seems like we should change the header, too, since it suffers from the same technical accuracy issue.)

chad added a comment.Dec 12 2015, 1:09 AM

you're just making a case for clowncopterize

chad added a comment.Dec 12 2015, 1:11 AM

Are these over-ridable by the app (Weigh In), etc?

epriestley added a comment.Dec 12 2015, 1:12 AM

Yeah, these are the generic defaults.

We'll still get "Weigh In" / "Leap Into Action" / "Eat Paste" stuff in the headers for non-serious installs, and EditEngines can override getCommentViewButtonText() to provide a non-serious action (but none of the current ones actually do -- I could add that).

chad accepted this revision.Dec 12 2015, 1:14 AM
chad edited edge metadata.

Yeah we need some flavor. If for no reason other than for people to complain on Twitter.

This revision is now accepted and ready to land.Dec 12 2015, 1:14 AM
epriestley added a comment.Dec 12 2015, 1:15 AM

Yeah, agreed. This isn't reducing silliness, just making the serious options MORE SUPER SERIOUS.

epriestley updated this revision to Diff 35665.Dec 12 2015, 1:25 AM
epriestley edited edge metadata.
  • Make specifying default (non-serious) text easier.
  • Specify default text for Paste and Maniphest.
  • Put some silly text on a button that's sure to ruffle a few feathers.
Closed by commit rP4b77bbd60c24: Clarify that the "Add Comment" button might not literally add a comment if… (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2015, 1:39 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Dec 12 2015, 1:39 AM

(Feel free to object or counterdiff if this text is too swashbuckley.)

joshuaspence awarded a token.Dec 12 2015, 2:40 AM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editengine/
4 lines

Diff 35662

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility