Page MenuHomePhabricator

Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment
ClosedPublic

Authored by epriestley on Dec 12 2015, 1:03 AM.

Diff Detail

Repository
rP Phabricator
Branch
ux1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9482
Build 11303: Run Core Tests
Build 11302: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley edited edge metadata.

Bland version.

I don't know if "Take Action" is too un-serious? Or how much flavor I can get into "Submit"?

(Maybe leaving "Add Comment" as the header is fine? But if we're changing the button it seems like we should change the header, too, since it suffers from the same technical accuracy issue.)

you're just making a case for clowncopterize

Are these over-ridable by the app (Weigh In), etc?

Yeah, these are the generic defaults.

We'll still get "Weigh In" / "Leap Into Action" / "Eat Paste" stuff in the headers for non-serious installs, and EditEngines can override getCommentViewButtonText() to provide a non-serious action (but none of the current ones actually do -- I could add that).

chad edited edge metadata.

Yeah we need some flavor. If for no reason other than for people to complain on Twitter.

This revision is now accepted and ready to land.Dec 12 2015, 1:14 AM

Yeah, agreed. This isn't reducing silliness, just making the serious options MORE SUPER SERIOUS.

epriestley edited edge metadata.
  • Make specifying default (non-serious) text easier.
  • Specify default text for Paste and Maniphest.
  • Put some silly text on a button that's sure to ruffle a few feathers.
This revision was automatically updated to reflect the committed changes.

(Feel free to object or counterdiff if this text is too swashbuckley.)