Page MenuHomePhabricator
Differential D14738

Disable tokenizer "Browse" button once tokenizer is full
ClosedPublic
Actions

Authored by epriestley on Dec 11 2015, 1:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 31, 2:18 AM
Unknown Object (File)
Wed, May 28, 12:25 PM
Unknown Object (File)
Tue, May 27, 7:52 AM
Unknown Object (File)
Sun, May 25, 6:43 AM
Unknown Object (File)
May 10 2025, 3:00 AM
Unknown Object (File)
May 10 2025, 3:00 AM
Unknown Object (File)
May 10 2025, 3:00 AM
Unknown Object (File)
May 8 2025, 9:37 PM
View All Files
Subscribers
None
Tokens
"Love" token, awarded by mememori.

Details

Reviewers
chad
Maniphest Tasks
T7858: Typeahead/Tokenizer Errata
Commits
Restricted Diffusion Commit
rP3680d959ddd6: Disable tokenizer "Browse" button once tokenizer is full
Summary

Ref T7858. Don't let users add multiple values to single-value tokenizers by using the "Browse" button.

Test Plan
  • Added a token, browse button was disabled.
  • Removed the token, browse button was enabled again.

Diff Detail

Repository
rP Phabricator
Branch
toklimit1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9464
Build 11276: Run Core Tests
Build 11275: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35646.Dec 11 2015, 1:37 AM
epriestley retitled this revision from to Disable tokenizer "Browse" button once tokenizer is full.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7858: Typeahead/Tokenizer Errata.
epriestley mentioned this in T7858: Typeahead/Tokenizer Errata.Dec 11 2015, 1:38 AM
chad accepted this revision.Dec 11 2015, 1:49 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 1:49 AM
Closed by commit rP3680d959ddd6: Disable tokenizer "Browse" button once tokenizer is full (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2015, 1:50 AM
This revision was automatically updated to reflect the committed changes.
mememori awarded a token.Dec 11 2015, 3:32 AM
epriestley mentioned this in T9952: Let "Land Revision" target branches other than master.Dec 14 2015, 10:27 PM
epriestley mentioned this in T9984: For limit=1 tokenizers, allow browse but replace the value.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
webroot/
rsrc/
externals/
javelin/
lib/
control/
tokenizer/
30 lines

Diff 35646

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js

Loading...
Phabricator · Built by Phacility