Paths

Table of Contentst

Differential D14603

Add a linter rule for curly brace array indexes
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 11:26 AM.

Tags

None

Referenced Files

	F14035577: D14603.diff
	Sun, Nov 10, 6:33 AM

	F14026722: D14603.id35568.diff
	Fri, Nov 8, 2:00 AM

	F14026720: D14603.id.diff
	Fri, Nov 8, 1:59 AM

	F14005050: D14603.id35323.diff
	Sun, Oct 27, 6:35 AM

	F14004890: D14603.diff
	Sun, Oct 27, 4:32 AM

	F13985147: D14603.id35568.diff
	Sun, Oct 20, 6:19 PM

	F13978465: D14603.diff
	Fri, Oct 18, 11:20 PM

	F13972566: D14603.id.diff
	Thu, Oct 17, 7:49 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCd2e778549727: Add a linter rule for curly brace array indexes

Summary

In PHP, both $x['key'] and $x{'key'} can be used to access an array (see http://stackoverflow.com/questions/8092248/php-curly-braces-in-array-notation), but the former should be preferred.

Test Plan

Added test cases.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9385
Build 11163: Run Core Tests
Build 11162: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	485 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	64 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	25 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	43 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 302 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35323.Nov 30 2015, 11:26 AM

joshuaspence retitled this revision from to Add a linter rule for curly brace array indexes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 11:26 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 30 2015, 1:08 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 1:08 PM

Improve handling of nested indexes

Closed by commit rARCd2e778549727: Add a linter rule for curly brace array indexes (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 8 2015, 8:18 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in rARC0c8124a2729d: Fix handling of empty array index.Dec 8 2015, 9:12 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistCurlyBraceArrayIndexXHPASTLinterRule.php

52 lines

__tests__/

ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

11 lines

curly-brace-array-index/

array.lint-test

9 lines

nested.lint-test

7 lines

whitespace.lint-test

7 lines

Diff 35568

src/__phutil_library_map__.php

Loading...

src/lint/linter/xhpast/rules/ArcanistCurlyBraceArrayIndexXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

Loading...

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/array.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/nested.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/whitespace.lint-test

Loading...