Paths

Table of Contentst

Differential D14690

Improve brace formatting linter rule
ClosedPublic
Actions

Authored by joshuaspence on Dec 7 2015, 10:33 AM.

Tags

None

Referenced Files

	F17675954: D14690.diff
	Sun, Jul 13, 9:33 AM

	Unknown Object (File)
	Jun 1 2025, 12:23 PM

	Unknown Object (File)
	May 30 2025, 5:07 AM

	Unknown Object (File)
	May 29 2025, 8:44 AM

	Unknown Object (File)
	May 28 2025, 2:11 PM

	Unknown Object (File)
	May 10 2025, 5:14 AM

	Unknown Object (File)
	May 10 2025, 5:14 AM

	Unknown Object (File)
	May 10 2025, 5:13 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCa6e81daad1bb: Improve brace formatting linter rule

Summary

Allow the brace formatting linter rule to complain about class X{}.

Test Plan

Updated unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9345
Build 11102: Run Core Tests
Build 11101: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	477 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	63 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	26 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	21 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	11 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 300 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35528.Dec 7 2015, 10:33 AM

joshuaspence retitled this revision from to Improve brace formatting linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 7 2015, 10:33 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 7 2015, 12:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 7 2015, 12:36 PM

Closed by commit rARCa6e81daad1bb: Improve brace formatting linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 7 2015, 8:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

8 lines

__tests__/

brace-formatting/

brace-formatting.lint-test

class.lint-test

14 lines

control-statement.lint-test

53 lines

declare.lint-test

4 lines

function.lint-test

27 lines

try-catch.lint-test

14 lines

Diff 35528

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/brace-formatting.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/class.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/control-statement.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/declare.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/function.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/brace-formatting/try-catch.lint-test

Loading...