Page MenuHomePhabricator

Clean up Phame Preview
ClosedPublic

Authored by chad on Dec 2 2015, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:15 AM
Unknown Object (File)
Wed, Apr 17, 12:58 PM
Unknown Object (File)
Thu, Apr 11, 7:49 PM
Unknown Object (File)
Sun, Apr 7, 11:01 AM
Unknown Object (File)
Mar 16 2024, 1:20 AM
Unknown Object (File)
Mar 8 2024, 12:48 PM
Unknown Object (File)
Mar 7 2024, 4:46 AM
Unknown Object (File)
Mar 7 2024, 4:46 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdd82cd49229a: Clean up Phame Preview
Summary

This adds a separate Publish/Unpublish step aside from Preview in Phame Posts. This allows easier access to publishing without previewing, though I left publish in tact on the preview page. Also cleaned up some minor transaction issues with mail.

Test Plan

New Post, Publish Post, Preview Post. Check mail logs. Get mail upon publish.

Diff Detail

Repository
rP Phabricator
Branch
phame-preview
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9232
Build 10934: Run Core Tests
Build 10933: arc lint + arc unit

Event Timeline

chad retitled this revision from to Clean up Phame Preview.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/post/PhamePostPublishController.php
40–41

Or $this->newDialog().

50

Or just return $dialog.

This revision is now accepted and ready to land.Dec 2 2015, 9:26 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.