Page MenuHomePhabricator
Differential D14642

Clean up Phame Preview
ClosedPublic
Actions

Authored by chad on Dec 2 2015, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 3:05 AM
Unknown Object (File)
Tue, Jan 28, 12:23 AM
Unknown Object (File)
Sat, Jan 25, 11:26 PM
Unknown Object (File)
Fri, Jan 24, 10:14 AM
Unknown Object (File)
Fri, Jan 24, 10:14 AM
Unknown Object (File)
Fri, Jan 24, 10:14 AM
Unknown Object (File)
Fri, Jan 24, 10:14 AM
Unknown Object (File)
Tue, Jan 21, 12:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdd82cd49229a: Clean up Phame Preview
Summary

This adds a separate Publish/Unpublish step aside from Preview in Phame Posts. This allows easier access to publishing without previewing, though I left publish in tact on the preview page. Also cleaned up some minor transaction issues with mail.

Test Plan

New Post, Publish Post, Preview Post. Check mail logs. Get mail upon publish.

Diff Detail

Repository
rP Phabricator
Branch
phame-preview
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9232
Build 10934: Run Core Tests
Build 10933: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35421.Dec 2 2015, 9:24 PM
chad retitled this revision from to Clean up Phame Preview.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2015, 9:24 PM
epriestley accepted this revision.Dec 2 2015, 9:26 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/post/PhamePostPublishController.php
40–41

Or $this->newDialog().

50

Or just return $dialog.

This revision is now accepted and ready to land.Dec 2 2015, 9:26 PM
Closed by commit rPdd82cd49229a: Clean up Phame Preview (authored by chad, committed by chad). · Explain WhyDec 2 2015, 9:28 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phame/
application/
1 line
controller/
post/
PhamePostPreviewController.php
PhamePostPublishController.php
11 lines
55 lines
11 lines
editor/
13 lines
storage/
5 lines

Diff 35421

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostPreviewController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostPublishController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
Phabricator · Built by Phacility