Make notification counts properly translatable
ClosedPublic
Actions

Authored by epriestley on Dec 2 2015, 7:38 PM.

Details

Reviewers

chad

Maniphest Tasks

T9132: Build an ApplicationEditor abstraction

Commits

Restricted Diffusion Commit
rP618cec23d8f0: Make notification counts properly translatable

Summary

Ref T9132. When I've touched PhabricatorApplication I keep hitting this bad pht() junk.

The warning is correct, these strings are not extactable and can not be translated.

Fix it so they can be extracted and translated.

Broadly, in all cases we want to render one of these:

95 Things (for fewer than some limit)
99+ Things (when we hit the limit)

Test Plan

Looked at homepage status counts, moused over them, saw reasonable strings. Grepped for removed method.

Diff Detail

Repository

rP Phabricator

Branch

ee30

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9225
Build 10923: Run Core Tests
Build 10922: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35414.Dec 2 2015, 7:38 PM

epriestley retitled this revision from to Make notification counts properly translatable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

@joshuaspence, I think we bumped into this somewhere else but I don't recall where. Might already have been fully resolved, or could have been in a dream.

chad accepted this revision.Dec 2 2015, 7:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 7:39 PM

How about adding a setLimit method to PhutilNumber instead?

Ah, right. I might have responded elsewhere, but my concerns are:

We only have this one use case.
I don't know that "add a + on the end" is the right rule for every language (for example, maybe "99+" in Spanish localizes better as "99~" or "¡99!").
The best localization of "99+" might depend on the rest of the sentence?

Basically, tiny known upside and big unknown possible downsides.