Page MenuHomePhabricator

Correct tooltip label for open audit count
ClosedPublic

Authored by epriestley on Jun 1 2016, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 3:16 AM
Unknown Object (File)
Mon, Apr 15, 9:12 AM
Unknown Object (File)
Sat, Apr 6, 1:43 AM
Unknown Object (File)
Sun, Mar 31, 11:37 PM
Unknown Object (File)
Thu, Mar 28, 4:45 PM
Unknown Object (File)
Wed, Mar 27, 5:39 PM
Unknown Object (File)
Wed, Mar 27, 4:47 PM
Unknown Object (File)
Wed, Mar 27, 4:42 PM
Subscribers
None

Details

Summary

Fixes T11071. This was a copy/paste error from D14638.

Test Plan

Screen Shot 2016-06-01 at 4.54.58 AM.png (284×812 px, 58 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Correct tooltip label for open audit count.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley removed a task: Restricted Maniphest Task.Jun 1 2016, 12:25 PM
chad edited edge metadata.

I guess some people use it.

This revision is now accepted and ready to land.Jun 1 2016, 2:03 PM

I don't think this feature is necessarily terrible, it's just really expensive to compute relative to its value. It looks like it's taking ~20-30% of homepage time on my local machine. If I fix a few other problems so the rest of the page gets cheaper, that could climb.

I'd rather have a 25% faster homepage than have these counts, and I'm not sure if it's worthwhile to spend hours making these counts faster and then maintaining the caching given how little value I think they provide.

This revision was automatically updated to reflect the committed changes.