Page MenuHomePhabricator
Differential D14625

Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 19, 5:25 AM
Unknown Object (File)
Wed, Feb 19, 5:09 AM
Unknown Object (File)
Wed, Feb 19, 5:09 AM
Unknown Object (File)
Wed, Feb 19, 5:09 AM
Unknown Object (File)
Sat, Feb 8, 11:56 PM
Unknown Object (File)
Sat, Feb 8, 11:56 PM
Unknown Object (File)
Sat, Feb 8, 11:56 PM
Unknown Object (File)
Sat, Feb 8, 11:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC8ed3c45c8226: Use `CaseInsensitiveArray` in…
Summary

Demonstrates the use of CaseInsensitiveArray. Depends on D14624.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9194
Build 10875: Run Core Tests
Build 10874: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
11 msArcanistFunctionCallShouldBeTypeCastXHPASTLinterRuleTestCase::Unknown Unit Message ("")
462 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
13 msArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
71 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
25 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (3 Failed · 288 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35384.Dec 1 2015, 8:03 PM
joshuaspence retitled this revision from to Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D14624: Add case-insensitive array.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 8:03 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 2 2015, 3:20 AM
epriestley edited edge metadata.

One of the unit tests looks very related, maybe just a libphutil version issue though?

This revision is now accepted and ready to land.Dec 2 2015, 3:20 AM
Closed by commit rARC8ed3c45c8226: Use `CaseInsensitiveArray` in… (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
22 lines

Diff 35384

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility