Page MenuHomePhabricator

Add a linter rule for curly brace array indexes
ClosedPublic

Authored by joshuaspence on Nov 30 2015, 11:26 AM.
Tags
None
Referenced Files
F15407295: D14603.diff
Tue, Mar 18, 4:45 PM
Unknown Object (File)
Feb 16 2025, 11:19 PM
Unknown Object (File)
Feb 4 2025, 5:38 AM
Unknown Object (File)
Feb 3 2025, 8:44 PM
Unknown Object (File)
Feb 1 2025, 2:38 AM
Unknown Object (File)
Feb 1 2025, 2:38 AM
Unknown Object (File)
Jan 29 2025, 9:12 PM
Unknown Object (File)
Jan 29 2025, 9:12 PM
Subscribers

Details

Summary

In PHP, both $x['key'] and $x{'key'} can be used to access an array (see http://stackoverflow.com/questions/8092248/php-curly-braces-in-array-notation), but the former should be preferred.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9134
Build 10779: Run Core Tests
Build 10778: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for curly brace array indexes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 1:08 PM
joshuaspence edited edge metadata.

Improve handling of nested indexes

This revision was automatically updated to reflect the committed changes.