Paths

Table of Contentst

Differential D14590

Update Almanac for newPage
ClosedPublic
Actions

Authored by chad on Nov 28 2015, 10:40 PM.

Tags

None

Referenced Files

	F15285561: D14590.diff
	Tue, Mar 4, 2:29 PM

	Unknown Object (File)
	Thu, Feb 27, 7:01 AM

	Unknown Object (File)
	Thu, Feb 20, 6:57 PM

	Unknown Object (File)
	Feb 8 2025, 11:54 PM

	Unknown Object (File)
	Feb 8 2025, 11:54 PM

	Unknown Object (File)
	Feb 8 2025, 11:54 PM

	Unknown Object (File)
	Feb 8 2025, 11:54 PM

	Unknown Object (File)
	Jan 29 2025, 10:43 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T9690: Remove calls to methods deprecated by newPage()

Commits

Restricted Diffusion Commit
rP0d7b59e3230e: Update Almanac for newPage

Summary

Swaps out for modern methods. Ref T9690

Test Plan

Check various Almanac pages, new devices, editing, lists.

Diff Detail

Repository

Branch

newpage-almanac

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9108
Build 10733: Run Core Tests
Build 10732: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35296.Nov 28 2015, 10:40 PM

chad retitled this revision from to Update Alamanac for newPage.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9690: Remove calls to methods deprecated by newPage().

Herald added a subscriber: Korvin. · View Herald TranscriptNov 28 2015, 10:40 PM

chad retitled this revision from Update Alamanac for newPage to Update Almanac for newPage.Nov 28 2015, 10:40 PM

One copypasta thing

src/applications/almanac/controller/AlmanacConsoleController.php
44	This one is great!
src/applications/almanac/controller/AlmanacDeviceEditController.php
155	Should be `$title`.
src/applications/almanac/controller/AlmanacDeviceViewController.php
61	Should be `$title`.
src/applications/almanac/controller/AlmanacInterfaceEditController.php
146	Should be `$title`.
src/applications/almanac/controller/AlmanacNetworkEditController.php
134	Should be `$title`.
src/applications/almanac/controller/AlmanacNetworkViewController.php
46	Should be `$title`.

This revision is now accepted and ready to land.Nov 28 2015, 10:42 PM

lulz

derps

Closed by commit rP0d7b59e3230e: Update Almanac for newPage (authored by chad, committed by chad). · Explain WhyNov 28 2015, 10:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

controller/

AlmanacBindingEditController.php

14 lines

AlmanacBindingViewController.php

17 lines

AlmanacConsoleController.php

14 lines

AlmanacDeviceEditController.php

13 lines

AlmanacDeviceViewController.php

23 lines

AlmanacInterfaceEditController.php

13 lines

AlmanacNetworkEditController.php

13 lines

AlmanacNetworkViewController.php

15 lines

AlmanacServiceEditController.php

13 lines

AlmanacServiceViewController.php

15 lines

Diff 35297

src/applications/almanac/controller/AlmanacBindingEditController.php

Loading...

src/applications/almanac/controller/AlmanacBindingViewController.php

Loading...

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...

src/applications/almanac/controller/AlmanacDeviceEditController.php

Loading...

src/applications/almanac/controller/AlmanacDeviceViewController.php

Loading...

src/applications/almanac/controller/AlmanacInterfaceEditController.php

Loading...

src/applications/almanac/controller/AlmanacNetworkEditController.php

Loading...

src/applications/almanac/controller/AlmanacNetworkViewController.php

Loading...

src/applications/almanac/controller/AlmanacServiceEditController.php

Loading...

src/applications/almanac/controller/AlmanacServiceViewController.php

Loading...