Page MenuHomePhabricator

Update Almanac for newPage
ClosedPublic

Authored by chad on Nov 28 2015, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:31 PM
Unknown Object (File)
Sun, Mar 17, 11:31 PM
Unknown Object (File)
Tue, Mar 5, 4:05 AM
Unknown Object (File)
Tue, Mar 5, 4:05 AM
Unknown Object (File)
Feb 3 2024, 7:22 AM
Unknown Object (File)
Feb 2 2024, 11:48 PM
Unknown Object (File)
Jan 17 2024, 9:28 PM
Unknown Object (File)
Dec 31 2023, 6:41 AM
Subscribers

Details

Summary

Swaps out for modern methods. Ref T9690

Test Plan

Check various Almanac pages, new devices, editing, lists.

Diff Detail

Repository
rP Phabricator
Branch
newpage-almanac
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9107
Build 10731: Run Core Tests
Build 10730: arc lint + arc unit

Event Timeline

chad retitled this revision from to Update Alamanac for newPage.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad retitled this revision from Update Alamanac for newPage to Update Almanac for newPage.Nov 28 2015, 10:40 PM
epriestley edited edge metadata.

One copypasta thing

src/applications/almanac/controller/AlmanacConsoleController.php
44

This one is great!

src/applications/almanac/controller/AlmanacDeviceEditController.php
155

Should be $title.

src/applications/almanac/controller/AlmanacDeviceViewController.php
61

Should be $title.

src/applications/almanac/controller/AlmanacInterfaceEditController.php
146

Should be $title.

src/applications/almanac/controller/AlmanacNetworkEditController.php
134

Should be $title.

src/applications/almanac/controller/AlmanacNetworkViewController.php
46

Should be $title.

This revision is now accepted and ready to land.Nov 28 2015, 10:42 PM
chad edited edge metadata.
  • derps
This revision was automatically updated to reflect the committed changes.