Differential D14564

Improve the "unexpected return value" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 10:52 PM.

Tags

None

Referenced Files

	F15520897: D14564.id35228.diff
	Sun, Apr 20, 9:04 AM

	F15514248: D14564.diff
	Fri, Apr 18, 1:12 AM

	F15507670: D14564.id35228.diff
	Tue, Apr 15, 9:56 PM

	F15497420: D14564.id35227.diff
	Sun, Apr 13, 10:27 AM

	F15486882: D14564.id35228.diff
	Thu, Apr 10, 9:54 AM

	F15467293: D14564.id35228.diff
	Thu, Apr 3, 1:58 PM

	F15453467: D14564.diff
	Sat, Mar 29, 12:03 PM

	F15429323: D14564.id35228.diff
	Mon, Mar 24, 1:40 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC9e78d15fc0c7: Improve the "unexpected return value" linter rule

Summary

Return values within constructors are acceptable if they are within a closure or anonymous function.

Test Plan

Added a test case.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9036
Build 10623: Run Core Tests
Build 10622: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	479 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	55 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	20 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 280 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35227.Nov 23 2015, 10:52 PM

joshuaspence retitled this revision from to Improve the "unexpected return value" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 10:52 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 23 2015, 10:52 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2015, 10:52 PM

Closed by commit rARC9e78d15fc0c7: Improve the "unexpected return value" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 11:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistUnexpectedReturnValueXHPASTLinterRule.php

15 lines

__tests__/

unexpected-return-value/

closure.lint-test

11 lines

Diff 35227

src/lint/linter/xhpast/rules/ArcanistUnexpectedReturnValueXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/unexpected-return-value/closure.lint-test

Loading...