Address feedback from D14530
ClosedPublic
Actions

Authored by epriestley on Nov 23 2015, 6:31 PM.

Tags

None

Referenced Files

	F18780537: D14554.id35204.diff
	Oct 12 2025, 5:03 PM

	F18611019: D14554.id35204.diff
	Sep 14 2025, 5:57 AM

	F18583927: D14554.id35204.diff
	Sep 11 2025, 11:38 AM

	F18579857: D14554.diff
	Sep 11 2025, 1:59 AM

	F18304879: D14554.id35204.diff
	Aug 23 2025, 11:06 PM

	F17928536: D14554.id35204.diff
	Jul 30 2025, 4:15 PM

	Unknown Object (File)
	Jul 2 2025, 4:37 AM

	Unknown Object (File)
	Jun 7 2025, 3:18 AM

View All Files

Subscribers

None

Details

Reviewers

alexmv
chad

Commits

rARCc71fe67ccbbe: Address feedback from D14530

Summary

See D14530.

Test Plan

Careful scrutiny.

Diff Detail

Repository

rARC Arcanist

Branch

dollardollarvaryall

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9015
Build 10593: Run Core Tests
Build 10592: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35203.Nov 23 2015, 6:31 PM

epriestley retitled this revision from to Address feedback from D14530.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, alexmv.

Ack -- sorry for having forgot that fixup.

This revision is now accepted and ready to land.Nov 23 2015, 6:31 PM

Closed by commit rARCc71fe67ccbbe: Address feedback from D14530 (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2015, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

2 lines

Diff 35203

View Options

src/repository/api/ArcanistGitAPI.php

Address feedback from D14530ClosedPublicActions