Examine upstream path instead of assuming "origin"
ClosedPublic
Actions

Authored by alexmv on Nov 20 2015, 6:50 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe730ececbc96: Examine upstream path instead of assuming "origin"

Summary

Instead of blindly assuming that "origin" is the repository that
arcanist should communicate with, use the remote that is configured
for the branch in git.

Test Plan

Used arc which with a branch with no upstream, an
origin/master upstream, and an upstream/master upstream -- the last of
which is being used to create and land this diff.

Diff Detail

Repository

rARC Arcanist

Branch

to-upstream/uri-from-upstream-remote

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8958
Build 10516: arc lint + arc unit

Event Timeline

alexmv updated this revision to Diff 35148.Nov 20 2015, 6:50 PM

alexmv retitled this revision from to Examine upstream path instead of assuming "origin".

alexmv updated this object.

alexmv edited the test plan for this revision. (Show Details)

alexmv added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 20 2015, 6:50 PM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence added a subscriber: joshuaspence.Nov 22 2015, 2:38 AM

epriestley accepted this revision.Nov 23 2015, 3:17 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/repository/api/ArcanistGitAPI.php
543	For consistency, prefer to write variables in strings as `{$variable}` instead of `$variable`: "remote.{$remote}.url" There's no behavioral difference, this syntax is just a little more explicit and consistent within the project.
548	We could maybe do this properly now, but whatever. I think the logic is fine as-is.