Differential D14544

Fix last child selector in phabricator-remarkup divs
ClosedPublic
Actions

Authored by chad on Nov 23 2015, 2:10 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T9793: Remarkup tables have uneven top and bottom margins

Commits

Restricted Diffusion Commit
rPff57b1e6e747: Fix last child selector in phabricator-remarkup divs

Summary

Fixes T9793, the selector is triggering on the last child of every child of phabricator-remarkup, not the last child of phabricator-remarkup

Test Plan

Checkout latest changelog

Diff Detail

Repository

rP Phabricator

Branch

remarkup-last-child

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8990
Build 10558: Run Core Tests
Build 10557: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35179.Nov 23 2015, 2:10 AM

chad retitled this revision from to Fix last child selector in phabricator-remarkup divs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9793: Remarkup tables have uneven top and bottom margins.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 23 2015, 2:10 AM

epriestley accepted this revision.Nov 23 2015, 5:08 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2015, 5:08 AM

Closed by commit rPff57b1e6e747: Fix last child selector in phabricator-remarkup divs (authored by chad, committed by chad). · Explain WhyNov 23 2015, 5:10 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9833: Remarkup comment areas have an excessively tall bottom margin.Nov 23 2015, 1:44 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

2 lines

Diff 35179

View Options

resources/celerity/map.php