Page MenuHomePhabricator
Differential D14519

Fix PHP compatibility linter after improvements to parsing of `use` statements
ClosedPublic
Actions

Authored by joshuaspence on Nov 19 2015, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 1:41 PM
Unknown Object (File)
Sun, Mar 2, 11:14 PM
Unknown Object (File)
Sat, Feb 22, 10:43 AM
Unknown Object (File)
Wed, Feb 12, 10:26 AM
Unknown Object (File)
Wed, Feb 12, 9:29 AM
Unknown Object (File)
Feb 8 2025, 11:50 PM
Unknown Object (File)
Feb 8 2025, 11:50 PM
Unknown Object (File)
Feb 8 2025, 11:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements
Summary

Fix the PHPCompatibilityXHPASTLinterRule after changes to the way in which XHPAST parses use statements. Depends on D14518.

Test Plan

Unit tests

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8931
Build 10476: Run Core Tests
Build 10475: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
148 msArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
88 msArcanistPHPCompatibilityXHPASTLinterRuleTestCase::Unknown Unit Message ("")
333 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
22 msArcanistRubyLinterTestCase::Unknown Unit Message ("")
17 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (4 Failed · 265 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35121.Nov 19 2015, 8:51 AM
joshuaspence retitled this revision from to Fix PHP compatibility linter after improvements to parsing of `use` statements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D14518: Improve parsing of `use` statements.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 8:51 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 19 2015, 4:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2015, 4:34 PM
Closed by commit rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
3 lines
__tests__/
php-compatibility/
2 lines

Diff 35121

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test

Loading...
Phabricator · Built by Phacility