Paths

Table of Contentst

Differential D14519

Fix PHP compatibility linter after improvements to parsing of `use` statements
ClosedPublic
Actions

Authored by joshuaspence on Nov 19 2015, 8:51 AM.

Tags

None

Referenced Files

	F15416643: D14519.id35129.diff
	Thu, Mar 20, 12:44 PM

	F15409790: D14519.id.diff
	Wed, Mar 19, 5:17 AM

	F15407650: D14519.diff
	Tue, Mar 18, 6:45 PM

	F15396668: D14519.id35121.diff
	Sun, Mar 16, 3:46 PM

	F15390266: D14519.diff
	Sat, Mar 15, 6:04 AM

	Unknown Object (File)
	Mon, Mar 3, 1:41 PM

	Unknown Object (File)
	Sun, Mar 2, 11:14 PM

	Unknown Object (File)
	Sat, Feb 22, 10:43 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements

Summary

Fix the PHPCompatibilityXHPASTLinterRule after changes to the way in which XHPAST parses use statements. Depends on D14518.

Test Plan

Unit tests

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8931
Build 10476: Run Core Tests
Build 10475: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	148 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	88 ms	ArcanistPHPCompatibilityXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	333 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	22 ms	ArcanistRubyLinterTestCase::Unknown Unit Message ("")
	17 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (4 Failed · 265 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35121.Nov 19 2015, 8:51 AM

joshuaspence retitled this revision from to Fix PHP compatibility linter after improvements to parsing of `use` statements.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14518: Improve parsing of `use` statements.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 8:51 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 19 2015, 4:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2015, 4:34 PM

Closed by commit rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

3 lines

__tests__/

php-compatibility/

php53-features.lint-test

2 lines

Diff 35121

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/php-compatibility/php53-features.lint-test

Loading...