Page MenuHomePhabricator

Write a linter rule for `$this` reassignment
ClosedPublic

Authored by joshuaspence on Nov 18 2015, 10:42 PM.
Tags
None
Referenced Files
F15416982: D14514.id.diff
Thu, Mar 20, 2:39 PM
Unknown Object (File)
Thu, Feb 27, 12:02 PM
Unknown Object (File)
Feb 8 2025, 11:50 PM
Unknown Object (File)
Jan 29 2025, 10:32 PM
Unknown Object (File)
Jan 27 2025, 9:31 PM
Unknown Object (File)
Jan 27 2025, 9:31 PM
Unknown Object (File)
Jan 24 2025, 10:01 AM
Unknown Object (File)
Jan 23 2025, 6:52 AM
Subscribers

Details

Summary

Re-assigning $this is an invalid PHP construct, see https://3v4l.org/TauX9.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8926
Build 10468: Run Core Tests
Build 10467: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Write a linter rule for `$this` reassignment.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.