Paths

Table of Contentst

Differential D14514

Write a linter rule for `$this` reassignment
ClosedPublic
Actions

Authored by joshuaspence on Nov 18 2015, 10:42 PM.

Tags

None

Referenced Files

	F14095758: D14514.diff
	Mon, Nov 25, 11:35 PM

	Unknown Object (File)
	Fri, Nov 8, 8:42 PM

	Unknown Object (File)
	Fri, Nov 8, 8:42 PM

	Unknown Object (File)
	Fri, Nov 8, 8:42 PM

	Unknown Object (File)
	Oct 15 2024, 10:07 AM

	Unknown Object (File)
	Oct 15 2024, 8:22 AM

	Unknown Object (File)
	Sep 30 2024, 10:00 PM

	Unknown Object (File)
	Sep 29 2024, 12:59 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC581829a99ee8: Write a linter rule for `$this` reassignment

Summary

Re-assigning $this is an invalid PHP construct, see https://3v4l.org/TauX9.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8921
Build 10458: Run Core Tests
Build 10457: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	542 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	445 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	31 ms	ArcanistRubyLinterTestCase::Unknown Unit Message ("")
	31 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	13 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 266 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35111.Nov 18 2015, 10:42 PM

joshuaspence retitled this revision from to Write a linter rule for `$this` reassignment.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2015, 10:42 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 18 2015, 11:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2015, 11:04 PM

Minor fix

Closed by commit rARC581829a99ee8: Write a linter rule for `$this` reassignment (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 19 2015, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistThisReassignmentXHPASTLinterRule.php

35 lines

__tests__/

ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

10 lines

this-reassignment/

class.lint-test

8 lines

4 lines

Diff 35111

src/__phutil_library_map__.php

Loading...

src/lint/linter/xhpast/rules/ArcanistThisReassignmentXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

Loading...

src/lint/linter/xhpast/rules/tests/this-reassignment/class.lint-test

Loading...

src/lint/linter/xhpast/rules/tests/this-reassignment/this.lint-test

Loading...