Page MenuHomePhabricator

Render Remarkup in emails
ClosedPublic

Authored by joshuaspence on Nov 18 2015, 8:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 6:37 AM
Unknown Object (File)
May 12 2025, 1:46 AM
Unknown Object (File)
May 9 2025, 10:34 PM
Unknown Object (File)
May 4 2025, 5:12 AM
Unknown Object (File)
Apr 30 2025, 4:45 AM
Unknown Object (File)
Apr 27 2025, 7:16 PM
Unknown Object (File)
Apr 27 2025, 6:30 PM
Unknown Object (File)
Apr 23 2025, 10:43 PM
Subscribers

Details

Summary

Ref T992. I noticed that ManiphestTask mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I think this is because the code calls addTextSection() rather than addRemarkupSection().

Test Plan

Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with ./bin/mail show-outbound). I didn't test the other affected applications.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8912
Build 10442: Run Core Tests
Build 10441: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Render Remarkup in emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.