Page MenuHomePhabricator

Render Remarkup in emails
ClosedPublic

Authored by joshuaspence on Nov 18 2015, 8:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 10:41 AM
Unknown Object (File)
Thu, Mar 28, 2:06 PM
Unknown Object (File)
Wed, Mar 27, 4:09 PM
Unknown Object (File)
Mar 19 2024, 9:09 PM
Unknown Object (File)
Mar 11 2024, 7:48 PM
Unknown Object (File)
Mar 6 2024, 5:21 AM
Unknown Object (File)
Mar 6 2024, 5:21 AM
Unknown Object (File)
Mar 6 2024, 4:45 AM
Subscribers

Details

Summary

Ref T992. I noticed that ManiphestTask mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I think this is because the code calls addTextSection() rather than addRemarkupSection().

Test Plan

Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with ./bin/mail show-outbound). I didn't test the other affected applications.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8912
Build 10442: Run Core Tests
Build 10441: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Render Remarkup in emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.