Page MenuHomePhabricator

Render Remarkup in emails
ClosedPublic

Authored by joshuaspence on Nov 18 2015, 8:52 PM.
Tags
None
Referenced Files
F18092379: D14511.id.diff
Thu, Aug 7, 9:55 AM
F18090694: D14511.diff
Wed, Aug 6, 5:04 PM
F18085332: D14511.id.diff
Tue, Aug 5, 7:09 PM
F18052438: D14511.id35208.diff
Mon, Aug 4, 2:32 AM
F18051292: D14511.diff
Sun, Aug 3, 10:40 PM
F17951085: D14511.id35102.diff
Fri, Aug 1, 12:59 AM
F17864982: D14511.diff
Mon, Jul 28, 2:46 AM
Unknown Object (File)
Jul 7 2025, 4:09 AM
Subscribers

Details

Summary

Ref T992. I noticed that ManiphestTask mail doesn't render Remarkup properly (instead, it renders Remarkup literally). I think this is because the code calls addTextSection() rather than addRemarkupSection().

Test Plan

Created a new Maniphest Task and saw Remarkup in the generated self-email (inspect the email contents with ./bin/mail show-outbound). I didn't test the other affected applications.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8912
Build 10442: Run Core Tests
Build 10441: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Render Remarkup in emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.