Page MenuHomePhabricator
Differential D14478

Move some files around
ClosedPublic
Actions

Authored by joshuaspence on Nov 13 2015, 11:12 PM.
Tags
None
Referenced Files
F13040758: D14478.diff
Tue, Apr 16, 5:06 PM
Unknown Object (File)
Thu, Apr 11, 12:56 PM
Unknown Object (File)
Thu, Apr 11, 12:56 PM
Unknown Object (File)
Thu, Apr 11, 12:54 PM
Unknown Object (File)
Sun, Mar 31, 6:03 PM
Unknown Object (File)
Fri, Mar 29, 8:46 AM
Unknown Object (File)
Mon, Mar 25, 8:23 PM
Unknown Object (File)
Sat, Mar 23, 3:10 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPcf2eb0dd5f92: Move some files around
Summary

Move some PhabricatorPolicyRule implementations to a subdirectory of the parent application.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8869
Build 10373: Run Core Tests
Build 10372: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35019.Nov 13 2015, 11:12 PM
joshuaspence retitled this revision from to Move some files around.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 13 2015, 11:12 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added inline comments.Nov 14 2015, 11:14 PM
src/applications/policy/rule/PhabricatorProjectsPolicyRule.php
3

I renamed this class to remove ambiguity for D14467.

joshuaspence added a child revision: D14467: Add a "members of project" policy rule.Nov 14 2015, 11:14 PM
joshuaspence removed a child revision: D14467: Add a "members of project" policy rule.Nov 14 2015, 11:18 PM
epriestley requested changes to this revision.Nov 15 2015, 4:40 PM
epriestley edited edge metadata.

I expect that the rename breaks existing policies (which use class names in the database, and are not migrated). Moves are fine.

This revision now requires changes to proceed.Nov 15 2015, 4:40 PM
joshuaspence updated this revision to Diff 35059.Nov 16 2015, 12:01 PM
joshuaspence edited edge metadata.
joshuaspence marked an inline comment as done.

Leave class name intact (will rename in D14467 instead)

epriestley accepted this revision.Nov 16 2015, 4:42 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 4:42 PM
Closed by commit rPcf2eb0dd5f92: Move some files around (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 16 2015, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35059

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/legalpad/policyrule/PhabricatorLegalpadSignaturePolicyRule.php

Loading...
View Options

src/applications/people/policyrule/PhabricatorAdministratorsPolicyRule.php

Loading...
View Options

src/applications/people/policyrule/PhabricatorUsersPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorAdministratorsPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorLunarPhasePolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorProjectsPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorUsersPolicyRule.php

Loading...
View Options

src/applications/project/policyrule/PhabricatorProjectsPolicyRule.php

Loading...
Phabricator · Built by Phacility