Yeah, some language may translate more naturally with the actual number.

OK sure.

Also, there were a bunch of strings that I couldn't change because I have no idea what this method does:

final public static function formatStatusCount(
  $count,
  $limit_string = '%s',
  $base_string = '%d') {
  if ($count == self::MAX_STATUS_ITEMS) {
    $count_str = pht($limit_string, ($count - 1).'+');
  } else {
    $count_str = pht($base_string, $count);
  }
  return $count_str;
}

I think we have to split those out, it's just doing this (except in a junky, untranslatable way):

if ($count > 99) {
  return pht('You have 99+ notifications.');
} else {
  return pht('You have %s notification(s).', new PhutilNumber($count));
}

Couldn't we just build that into PhutilNumber with some setDisplayLimit method?

In theory, but I'd guess some languages may want to represent "99+" in a different way than by adding "+" to the end of the number, and I think notification counts are the only place where we do that.

In D14474#162556, @epriestley wrote:

In theory, but I'd guess some languages may want to represent "99+" in a different way than by adding "+" to the end of the number, and I think notification counts are the only place where we do that.

Right, so you just render it as pht('%d+', $real_count)?