Use monograms for Herald URIs
ClosedPublic
Actions

Authored by joshuaspence on Nov 12 2015, 9:18 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPfeca8fbdece3: Use monograms for Herald URIs

Summary

I think HeraldRules are the only objects which have monograms but are not accesible via /{$monogram}. This diff changes the /herald/rule/{$id} URI to /{$monogram}.

Test Plan

Clicked a bunch of links in Herald to ensure there were no dead links.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 8799
Build 10258: Run Core Tests
Build 10257: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	941 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 290 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34989.Nov 12 2015, 9:18 AM

joshuaspence retitled this revision from to Use monograms for Herald URIs.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 12 2015, 9:18 AM

Herald added a subscriber: Korvin. · View Herald Transcript

I have half (?) a change to try to give objects a consistent way to generate URIs, but it ended up getting out of control really fast and I'm not totally happy with it. But I think I'll be able to find a way forward eventually.

This revision is now accepted and ready to land.Nov 12 2015, 6:40 PM

Closed by commit rPfeca8fbdece3: Use monograms for Herald URIs (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 12 2015, 8:07 PM

This revision was automatically updated to reflect the committed changes.