Page MenuHomePhabricator

Use monograms for Herald URIs
ClosedPublic

Authored by joshuaspence on Nov 12 2015, 9:18 AM.
Tags
None
Referenced Files
F13268272: D14469.diff
Wed, May 29, 4:51 AM
F13255912: D14469.id35000.diff
Sat, May 25, 9:09 AM
F13255911: D14469.id34989.diff
Sat, May 25, 9:09 AM
F13255908: D14469.id.diff
Sat, May 25, 9:08 AM
F13255906: D14469.diff
Sat, May 25, 9:08 AM
F13253790: D14469.diff
Sat, May 25, 2:56 AM
F13232611: D14469.diff
Tue, May 21, 1:24 AM
F13214377: D14469.id35000.diff
Fri, May 17, 10:11 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPfeca8fbdece3: Use monograms for Herald URIs
Summary

I think HeraldRules are the only objects which have monograms but are not accesible via /{$monogram}. This diff changes the /herald/rule/{$id} URI to /{$monogram}.

Test Plan

Clicked a bunch of links in Herald to ensure there were no dead links.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 8799
Build 10258: Run Core Tests
Build 10257: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Use monograms for Herald URIs.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I have half (?) a change to try to give objects a consistent way to generate URIs, but it ended up getting out of control really fast and I'm not totally happy with it. But I think I'll be able to find a way forward eventually.

This revision is now accepted and ready to land.Nov 12 2015, 6:40 PM
This revision was automatically updated to reflect the committed changes.