In D14446#161928, @joshuaspence wrote:

Attempt to restart daemons every 5 seconds.

I"m just playing around with getting the daemons to reload, but this doesn't seem to work... any thoughts?

sh: 1: kill: No such process

Using posix_kill instead of exec('kill ...') seemed to fix this.

I'm thinking some kind of new module/extension class:

abstract class PhutilDaemonOverseerModule extends Phobject { 

// ...

$modules = id(new PhutilClassMapQuery())
  ->setAncestorClass(__CLASS__)
  ->execute()

// ...

}

And then build the listeners:

$this->modules = PhutilDaemonOverseerModule::getAllModules();

And then you can call them to change behavior:

foreach ($this->modules as $module) {
  if ($module->shouldRestartDaemons()) {
    $this->restartEverything();
  }
}

I think this should work because phabricator/scripts/daemon/phd-daemon loads the whole Phabricator environment.

We could also use real events but I think classtrees are probably a bit better here, probably. I generally prefer classtrees over events where we can reasonably use them, since I think the totality of their behaviors are much better.

I don't love the name either, I'll yell if I come up with anything better.

I think we need posix anyway (e.g., for posix_getpgid() and posix_setsid()).

The original kill probably was to avoid posix, but I think we're fine relying on it now.

I will fill out the diff summary once this stuff is more concrete.

master does seem to work properly for me locally (OS X):

epriestley@orbital ~/dev/phabricator $ ps auxwww | grep -i resist
epriestley      89251   0.0  0.0  2432772    672 s025  S+   12:38PM   0:00.00 grep -i resist
epriestley      89245   0.0  0.1  2564196  11576   ??  S    12:37PM   0:00.02 php /Users/epriestley/dev/core/lib/libphutil/scripts/daemon/torture/resist-death.php

epriestley@orbital ~/dev/phabricator $ ./bin/phd stop
Interrupting process 89243...
Terminating process 89243...
Process 89243 exited.

epriestley@orbital ~/dev/phabricator $ ps auxwww | grep -i resist
epriestley      89258   0.4  0.0  2432772    672 s025  S+   12:38PM   0:00.00 grep -i resist

Doesn't work for me at master on Ubuntu 14.04.

Hmm, it works on our production install running Ubuntu 12.04.

Ah I see... it works if I launch PhutilProcessGroupDaemon, but not if I run it with debug.