Differential D14457

Make deleting a blog a little easier to recover from
ClosedPublic
Actions

Authored by chad on Nov 10 2015, 7:52 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9360: Unbeta Phame

Commits

Restricted Diffusion Commit
rP1365b37fae81: Make deleting a blog a little easier to recover from

Summary

We currently orphan posts when you delete a blog. Fixes some visibility and permission errors when that happens. Also... should allow you to archive posts.

Test Plan

Delete a blog, visit a post I made, still can see it.

Diff Detail

Repository

rP Phabricator

Branch

no-blog

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8767
Build 10202: Run Core Tests
Build 10201: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34957.Nov 10 2015, 7:52 PM

chad retitled this revision from to Make deleting a blog a little easier to recover from.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 10 2015, 7:52 PM

chad added a task: T9360: Unbeta Phame.Nov 10 2015, 7:54 PM

We should disable this stuff rather than deleting it, and PostQuery should just refuse to load posts that don't have a blog. But we can fix that up later.

This revision is now accepted and ready to land.Nov 10 2015, 7:55 PM

Closed by commit rP1365b37fae81: Make deleting a blog a little easier to recover from (authored by chad, committed by chad). · Explain WhyNov 10 2015, 7:55 PM

This revision was automatically updated to reflect the committed changes.