Page MenuHomePhabricator

Make deleting a blog a little easier to recover from
ClosedPublic

Authored by chad on Nov 10 2015, 7:52 PM.
Tags
None
Referenced Files
F12826369: D14457.diff
Thu, Mar 28, 9:25 AM
Unknown Object (File)
Tue, Mar 5, 2:22 AM
Unknown Object (File)
Feb 6 2024, 9:36 PM
Unknown Object (File)
Feb 5 2024, 5:32 PM
Unknown Object (File)
Feb 4 2024, 5:29 PM
Unknown Object (File)
Feb 3 2024, 7:12 AM
Unknown Object (File)
Jan 31 2024, 11:17 PM
Unknown Object (File)
Dec 27 2023, 7:27 AM
Subscribers

Details

Summary

We currently orphan posts when you delete a blog. Fixes some visibility and permission errors when that happens. Also... should allow you to archive posts.

Test Plan

Delete a blog, visit a post I made, still can see it.

Diff Detail

Repository
rP Phabricator
Branch
no-blog
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8767
Build 10202: Run Core Tests
Build 10201: arc lint + arc unit

Event Timeline

chad retitled this revision from to Make deleting a blog a little easier to recover from.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

We should disable this stuff rather than deleting it, and PostQuery should just refuse to load posts that don't have a blog. But we can fix that up later.

This revision is now accepted and ready to land.Nov 10 2015, 7:55 PM
This revision was automatically updated to reflect the committed changes.

ah true, then we don't orphan the post, it just stays on an archived blog.