Differential D14423

Fix Oblivious skin summary remarkup and partially fix title
ClosedPublic
Actions

Authored by epriestley on Nov 6 2015, 8:22 PM.

Details

Reviewers

chad

Maniphest Tasks

T9546: Phame "Oblivious" skin a few rough edges

Commits

Restricted Diffusion Commit
rP80f1d0160210: Fix Oblivious skin summary remarkup and partially fix title

Summary

Ref T9546. I only got the title to always show the blog title (better than nothing) -- showing the post title properly isn't trivial and is more work than I want to do right now.

Test Plan

Description now has remarkup.
Title now shows blog title (better than nothing).

Diff Detail

Repository

rP Phabricator

Branch

phame1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/phame/skins/PhameBasicTemplateBlogSkin.php:121	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 8654
Build 10026: Run Core Tests
Build 10025: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34846.Nov 6 2015, 8:22 PM

epriestley retitled this revision from to Fix Oblivious skin summary remarkup and partially fix title.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9546: Phame "Oblivious" skin a few rough edges.

yay im not crazy.

This revision is now accepted and ready to land.Nov 6 2015, 8:23 PM

Yeah, this definitely isn't easy/straightforward, especially fixing the title stuff.

Closed by commit rP80f1d0160210: Fix Oblivious skin summary remarkup and partially fix title (authored by epriestley, committed by epriestley). · Explain WhyNov 6 2015, 8:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

externals/

skins/

oblivious/

header.php

2 lines

src/

applications/

phame/

skins/

PhameBasicTemplateBlogSkin.php

23 lines

Diff 34846

View Options

externals/skins/oblivious/header.php