Page MenuHomePhabricator
Differential D14414

Updating xaction titles for Phurl updates
ClosedPublic
Actions

Authored by lpriestley on Nov 5 2015, 6:50 PM.
Tags
None
Referenced Files
F15515885: D14414.id.diff
Fri, Apr 18, 2:07 PM
F15511371: D14414.diff
Thu, Apr 17, 1:57 AM
F15472043: D14414.diff
Sat, Apr 5, 10:45 AM
F15446289: D14414.id34823.diff
Thu, Mar 27, 6:12 PM
F15439880: D14414.id34822.diff
Wed, Mar 26, 10:01 AM
F15431431: D14414.id.diff
Mon, Mar 24, 12:17 PM
F15399235: D14414.id34824.diff
Mar 17 2025, 3:28 AM
F15376972: D14414.diff
Mar 13 2025, 7:00 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8992: Actually implement an `alias` field on Phurl URL's
Commits
Restricted Diffusion Commit
rP9132b565d5c5: Updating xaction titles for Phurl updates
Summary

Ref T8992, Cleaning up and clarifying xaction titles for Phurl creation/updating.

Test Plan

Create a Phurl, update information, make sure xaction in the timeline makes sense.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 34822.Nov 5 2015, 6:50 PM
lpriestley retitled this revision from to Updating xaction titles for Phurl updates.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8992: Actually implement an `alias` field on Phurl URL's.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 6:50 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 5 2015, 6:51 PM
epriestley edited edge metadata.

I think the $old != $new clauses should be unnecessary -- we should be dropping those transactions before we ever get to rendering them. Rest of this looks good.

This revision is now accepted and ready to land.Nov 5 2015, 6:51 PM
lpriestley updated this revision to Diff 34823.Nov 5 2015, 6:54 PM
lpriestley edited edge metadata.

Removing redundant check for $old != $new

Closed by commit rP9132b565d5c5: Updating xaction titles for Phurl updates (authored by lpriestley, committed by lpriestley). · Explain WhyNov 5 2015, 6:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
storage/
55 lines

Diff 34824

View Options

src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php

Loading...
Phabricator · Built by Phacility