Paths

Table of Contentst

Differential D14414

Updating xaction titles for Phurl updates
ClosedPublic
Actions

Authored by lpriestley on Nov 5 2015, 6:50 PM.

Tags

None

Referenced Files

	F14059426: D14414.diff
	Sun, Nov 17, 7:36 PM

	F14051348: D14414.diff
	Fri, Nov 15, 12:02 AM

	F14034501: D14414.diff
	Sun, Nov 10, 12:40 AM

	F14029911: D14414.id34824.diff
	Fri, Nov 8, 10:34 PM

	F14029909: D14414.id34823.diff
	Fri, Nov 8, 10:34 PM

	F14029908: D14414.id34822.diff
	Fri, Nov 8, 10:34 PM

	F14029907: D14414.diff
	Fri, Nov 8, 10:34 PM

	F14026554: D14414.id.diff
	Fri, Nov 8, 1:39 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8992: Actually implement an `alias` field on Phurl URL's

Commits

Restricted Diffusion Commit
rP9132b565d5c5: Updating xaction titles for Phurl updates

Summary

Ref T8992, Cleaning up and clarifying xaction titles for Phurl creation/updating.

Test Plan

Create a Phurl, update information, make sure xaction in the timeline makes sense.

Diff Detail

Repository

Branch

phurltransactiontitles

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8632
Build 9991: Run Core Tests
Build 9990: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34822.Nov 5 2015, 6:50 PM

lpriestley retitled this revision from to Updating xaction titles for Phurl updates.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8992: Actually implement an `alias` field on Phurl URL's.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 6:50 PM

Herald added a subscriber: Korvin. · View Herald Transcript

I think the $old != $new clauses should be unnecessary -- we should be dropping those transactions before we ever get to rendering them. Rest of this looks good.

This revision is now accepted and ready to land.Nov 5 2015, 6:51 PM

Removing redundant check for $old != $new

Closed by commit rP9132b565d5c5: Updating xaction titles for Phurl updates (authored by lpriestley, committed by lpriestley). · Explain WhyNov 5 2015, 6:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

storage/

PhabricatorPhurlURLTransaction.php

55 lines

Diff 34823

src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php

Loading...