Page MenuHomePhabricator
Differential D14414

Updating xaction titles for Phurl updates
ClosedPublic
Actions

Authored by lpriestley on Nov 5 2015, 6:50 PM.
Tags
None
Referenced Files
F19015137: D14414.diff
Sat, Nov 22, 11:23 PM
F18763663: D14414.diff
Oct 7 2025, 1:21 AM
F18671954: D14414.id34822.diff
Sep 25 2025, 6:03 AM
F18658143: D14414.diff
Sep 23 2025, 5:00 AM
F18364876: D14414.id34822.diff
Aug 27 2025, 8:01 PM
F18364874: D14414.id34823.diff
Aug 27 2025, 8:01 PM
F18095630: D14414.id34823.diff
Aug 8 2025, 1:05 AM
F18089086: D14414.id34824.diff
Aug 6 2025, 10:21 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8992: Actually implement an `alias` field on Phurl URL's
Commits
Restricted Diffusion Commit
rP9132b565d5c5: Updating xaction titles for Phurl updates
Summary

Ref T8992, Cleaning up and clarifying xaction titles for Phurl creation/updating.

Test Plan

Create a Phurl, update information, make sure xaction in the timeline makes sense.

Diff Detail

Repository
rP Phabricator
Branch
phurltransactiontitles
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8631
Build 9989: Run Core Tests
Build 9988: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34822.Nov 5 2015, 6:50 PM
lpriestley retitled this revision from to Updating xaction titles for Phurl updates.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8992: Actually implement an `alias` field on Phurl URL's.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 6:50 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 5 2015, 6:51 PM
epriestley edited edge metadata.

I think the $old != $new clauses should be unnecessary -- we should be dropping those transactions before we ever get to rendering them. Rest of this looks good.

This revision is now accepted and ready to land.Nov 5 2015, 6:51 PM
lpriestley updated this revision to Diff 34823.Nov 5 2015, 6:54 PM
lpriestley edited edge metadata.

Removing redundant check for $old != $new

Closed by commit rP9132b565d5c5: Updating xaction titles for Phurl updates (authored by lpriestley, committed by lpriestley). · Explain WhyNov 5 2015, 6:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
storage/
101 lines

Diff 34822

View Options

src/applications/phurl/storage/PhabricatorPhurlURLTransaction.php

Loading...
Phabricator · Built by Phacility