Paths

Table of Contentst

Differential D14413

Preventing duplicate empty string aliases in Phurl's
ClosedPublic
Actions

Authored by lpriestley on Nov 5 2015, 6:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8992: Actually implement an `alias` field on Phurl URL's

Commits

Restricted Diffusion Commit
rPe2c0df4fb49f: Preventing duplicate empty string aliases in Phurl's

Summary

Ref T8992, Make it impossible to save an empty string alias for a Phurl.

Test Plan

Create two Phurl's with non-empty aliases
Delete aliases for both Phurl's
Previously, this wouldn't allow to save the second Phurl because of a duplicate alias. Current diff should save empty alias as null, not empty string.

Diff Detail

Repository

rP Phabricator

Branch

phurlemptyaliasdups

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8629
Build 9986: Run Core Tests
Build 9985: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34820.Nov 5 2015, 6:13 PM

lpriestley retitled this revision from to Preventing duplicate empty string aliases in Phurl's.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8992: Actually implement an `alias` field on Phurl URL's.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 6:13 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 5 2015, 6:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 5 2015, 6:13 PM

Closed by commit rPe2c0df4fb49f: Preventing duplicate empty string aliases in Phurl's (authored by lpriestley, committed by lpriestley). · Explain WhyNov 5 2015, 6:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

editor/

PhabricatorPhurlURLEditor.php

6 lines

Diff 34820

View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Preventing duplicate empty string aliases in Phurl'sClosedPublicActions